Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 26, 2025

Addresses review feedback on #1164 — the CI workflow was using npm run to execute scripts after installing dependencies with pnpm, creating inconsistency.

Changes

  • Replaced all npm run <script> with pnpm <script> in .github/workflows/ci_reusable.yaml:
    • prettier
    • tsc
    • lint
    • build (2 occurrences)
- - run: npm run prettier
- - run: npm run tsc
- - run: npm run lint
- - run: npm run build
+ - run: pnpm prettier
+ - run: pnpm tsc
+ - run: pnpm lint
+ - run: pnpm build

Note: npx commands for Playwright and Fleek CLI left unchanged as these invoke external CLIs, not project scripts.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: levalleux-ludo <7184124+levalleux-ludo@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 26, 2025

Deploying boson-dapp-testing with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98c0a23
Status: ✅  Deploy successful!
Preview URL: https://22b97f6a.interface-a9d.pages.dev
Branch Preview URL: https://copilot-sub-pr-1164-again.interface-a9d.pages.dev

View logs

Copilot AI changed the title [WIP] Address feedback on npm to pnpm migration PR Replace npm run with pnpm in CI workflow Nov 26, 2025
Copilot AI requested a review from levalleux-ludo November 26, 2025 11:59
@levalleux-ludo levalleux-ludo deleted the copilot/sub-pr-1164-again branch November 26, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants