-
Notifications
You must be signed in to change notification settings - Fork 3
chore: migrate from npm to pnpm #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying boson-dapp-testing with
|
| Latest commit: |
aa252dc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82d8a5a2.interface-a9d.pages.dev |
| Branch Preview URL: | https://migrate-npm-to-pnpm.interface-a9d.pages.dev |
|
@levalleux-ludo I've opened a new pull request, #1165, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the project's package manager from npm to pnpm. The migration includes TypeScript type fixes that became necessary due to stricter type checking in the pnpm resolution strategy.
- Added pnpm enforcement via preinstall script
- Updated CI/CD workflows to use pnpm
- Fixed TypeScript type errors in react-select and styled-components usage
- Consolidated imports from
@bosonprotocol/core-sdkto@bosonprotocol/react-kit
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added preinstall script, updated scripts to use pnpm, pinned package versions, removed @types/styled-components |
| README.md | Updated installation instructions from npm to pnpm |
| .github/workflows/fleek-deploy.yaml | Updated CI workflow to install and use pnpm instead of npm |
| .github/workflows/ci_reusable.yaml | Updated CI workflow for pnpm, removed test/coverage steps |
| src/lib/types/styled.d.ts | Added DefaultTheme declaration file for styled-components |
| src/lib/styles/GlobalStyle.tsx | Added type cast for cssVars to RuleSet |
| src/components/app/index.tsx | Added type cast for theme as DefaultTheme |
| src/pages/explore/ExploreSelect.tsx | Added CSSObjectWithLabel type casts and SetStateAction type annotation |
| src/components/form/Select.tsx | Added CSSObjectWithLabel type casts and type annotations |
| src/components/form/Phone.tsx | Added explicit type annotations for react-select component props |
| src/components/form/CountrySelect.tsx | Added explicit type annotations for react-select component props |
| src/pages/profile/seller/SellerSocial.tsx | Consolidated imports and updated type references to subgraph namespace |
| src/lib/utils/transactions.ts | Updated import from @bosonprotocol/core-sdk to react-kit |
| src/lib/utils/hooks/useIpfsStorage.ts | Consolidated imports from core-sdk and react-kit |
| src/lib/utils/hooks/useCurrentSellers.ts | Updated type references and removed unnecessary fallback |
| src/lib/utils/hooks/seller/useUpdateSellerMetadata.ts | Updated type reference to subgraph namespace |
| src/lib/utils/hooks/seller/useUpdateSeller.ts | Updated type reference to subgraph namespace |
| src/components/modal/components/Profile/utils.ts | Updated type references and fixed redundant nullish coalescing |
Comments suppressed due to low confidence (2)
.github/workflows/ci_reusable.yaml:203
- [nitpick] The second build command (for dr_center) still uses
npm run. For consistency with the pnpm migration, consider usingpnpm run buildorpnpm buildinstead.
run: npm run build
src/lib/styles/GlobalStyle.tsx:1
- The type cast duplicates the type definition from lines 10-24. This creates maintenance burden as changes to the props interface must be kept in sync in two places. Consider extracting this to a shared type definition to ensure consistency.
import { cssVars } from "@bosonprotocol/react-kit";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@levalleux-ludo I've opened a new pull request, #1166, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.