Skip to content

fix: handle binary content properly in WebDAV requests #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jairo-bc merged 1 commit into from
Oct 28, 2025
Merged

fix: handle binary content properly in WebDAV requests #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions server/plugins/renderer/renderer.module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,24 @@ internals.getResponse = async (request) => {
const contentType = response.headers['content-type'] || '';
const isResponseJson = contentType.toLowerCase().includes('application/json');
const isWebDavRequest = request.path.startsWith('/content');
const isBinaryContent = contentType
.toLowerCase()
.match(/^(image|video|audio|application\/octet-stream|application\/pdf)/);
let bcAppData = response.data;

if (isResponseJson) {
bcAppData = JSON.parse(await readFromStream(response.data));
} else if (isWebDavRequest) {
const tappedStream = tapStream(response.data, (body) => {
return body;
});
bcAppData = await readStream(tappedStream);
if (isBinaryContent) {
// For binary content, don't read the stream - pass it through as-is
bcAppData = response.data;
} else {
// For text content, read as string
const tappedStream = tapStream(response.data, (body) => {
return body;
});
bcAppData = await readStream(tappedStream, false);
}
}
// cache response
cache.put(
Expand Down