fix: handle binary content properly in WebDAV requests #1332
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents corruption of binary files (images, videos, audio, PDFs) by passing streams through as-is instead of reading them as text for WebDAV content requests.
What?
This pull request fixes an issue where binary files (such as images, videos, audio, PDFs) served via WebDAV endpoints were being corrupted. The bug was caused by reading binary streams as text, which altered the file contents. The new logic detects binary content types and passes their streams through as-is, preventing corruption.
The regression was introduced in commit
20e1143e54c0ccfb2197c16b654ee5b098399ec9, which changed how streams were handled for WebDAV requests.Tickets / Documentation
No existing tickets or documentation were found for this issue. The problem was identified and traced to the above commit.
Steps to Test
test.png) to the WebDAV directory:/content/images/test.png./content/images/test.pngin an img tag.Screenshots (if appropriate)
cc @bigcommerce/storefront-team