Allow BRP schedule.graph to initialize the schedules it is collecting.#23743
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Apr 12, 2026
Merged
Allow BRP schedule.graph to initialize the schedules it is collecting.#23743alice-i-cecile merged 3 commits intobevyengine:mainfrom
schedule.graph to initialize the schedules it is collecting.#23743alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
andriyDev
added
C-Usability
andriyDev
force-pushed
the
brp-init-schedules
branch
from
63fc5bc to
d579593
Compare
kfc35
approved these changes
Apr 10, 2026
ChristopherBiscardi
approved these changes
Apr 10, 2026
Zeophlite
approved these changes
Apr 10, 2026
Zeophlite
added
S-Ready-For-Final-Review
Member
|
@andriyDev I would like to improve the tests per @ChristopherBiscardi before we merge. |
alice-i-cecile
added
S-Waiting-on-Author
andriyDev
added
S-Ready-For-Final-Review
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Apr 14, 2026
…ng. (bevyengine#23743) # Objective - In bevyengine#23733, we started using the `ScheduleData` API for the BRP `schedule.graph` endpoint. - This had a consequence that only schedules that were initialized (i.e., previously ran) could be returned. - In addition, the schedule data was missing edges for automatically inserted `apply_deferred` systems. ## Solution - Cache the `ScheduleBuildMetadata` whenever a schedule is built (the `ScheduleBuilt` event). - Lookup this metadata when BRP `schedule.graph` runs, and use it to extract the schedule data. - This metadata includes the edges for automatically inserted systems, making the resulting ScheduleData more accurate to the running schedule. - If the schedule needs to be built (has changed/hasn't run before), build the schedule which automatically caches its metadata. ## Testing - Added a test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ScheduleDataAPI for the BRPschedule.graphendpoint.apply_deferredsystems.Solution
ScheduleBuildMetadatawhenever a schedule is built (theScheduleBuiltevent).schedule.graphruns, and use it to extract the schedule data.Testing