Skip to content

Add TextEditChange event#23665

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Zeophlite:text-edit-change
Apr 5, 2026
Merged

Add TextEditChange event#23665
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Zeophlite:text-edit-change

Conversation

@Zeophlite
Copy link
Copy Markdown
Contributor

Objective

  • There's no event when the pending TextEdit's are consumed

Solution

  • Add the event

Testing

  • CI

@Zeophlite Zeophlite added A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 5, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in UI Apr 5, 2026
@Zeophlite Zeophlite added this to the 0.19 milestone Apr 5, 2026
@Zeophlite Zeophlite requested a review from ickshonpe April 5, 2026 02:05
@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 5, 2026
@viridia
Copy link
Copy Markdown
Contributor

viridia commented Apr 5, 2026

I'd like to see us gradually move in the direction of only triggering this event when there's an actual change, but we don't need to do that right now. For some kinds of text actions (cursor motion, copy), it's easy to tell that nothing has changed, whereas for other kinds (replacing selection with identical text, clearing an already-cleared buffer) are likely to remain false positives. The only way to do this perfectly is to keep around a copy of the buffer and compare them, which would be expensive. But I think it's reasonable to go after the low-hanging fruit.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 5, 2026
Merged via the queue into bevyengine:main with commit 8455e8f Apr 5, 2026
40 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in UI Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants