Add TextEditChange event#23665
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Apr 5, 2026
Merged
Conversation
viridia
approved these changes
Apr 5, 2026
ickshonpe
approved these changes
Apr 5, 2026
Contributor
|
I'd like to see us gradually move in the direction of only triggering this event when there's an actual change, but we don't need to do that right now. For some kinds of text actions (cursor motion, copy), it's easy to tell that nothing has changed, whereas for other kinds (replacing selection with identical text, clearing an already-cleared buffer) are likely to remain false positives. The only way to do this perfectly is to keep around a copy of the buffer and compare them, which would be expensive. But I think it's reasonable to go after the low-hanging fruit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
TextEdit's are consumedSolution
Testing