Fix dof and background motion vectors on webgpu#23629
Open
beicause wants to merge 1 commit intobevyengine:mainfrom
Open
Fix dof and background motion vectors on webgpu#23629beicause wants to merge 1 commit intobevyengine:mainfrom
beicause wants to merge 1 commit intobevyengine:mainfrom
Conversation
beicause
force-pushed
the
webgpu-dof-and-background-motion-vectors
branch
from
3defd77 to
1d747f3
Compare
alice-i-cecile
added
C-Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
WebGPU-only fix extracted from #22554 and #22555. Fixes #20459
Solution
Fix normal + motion vector prepass by setting write mask to empty. This is a firefox/wgpu bug that it's not validated gfx-rs/wgpu#9147, but chromium does.
Fix dof with bokeh mode. I guess it's
naga_oilbug but I'm not sure.Testing
I tested dof and skybox examples on web.