Replace unnecessary &Window in exit_on_all_closed with With<Window>#23625
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Apr 2, 2026
Merged
Replace unnecessary &Window in exit_on_all_closed with With<Window>#23625alice-i-cecile merged 2 commits intobevyengine:mainfrom
&Window in exit_on_all_closed with With<Window>#23625alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Apr 2, 2026
alice-i-cecile
added
D-Trivial
Member
|
Yay! Very nice. I like getting rid of those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny optimization I came across while working on #23624