Make Bounded3d dyn-compatible

[omeranson]

Objective

Make Bounded3d a dyn-compatible object. This is so that components can contain a dyn Bounded3d type member, and won't need a template.

I am suggesting this as a draft, because there is an alternative that may be preferable (shown below). There are also other such traits, e.g., Bounded2d that will need to go through the same process for the same result.

Solution

Refractor Bounded3d so that its methods accept Isometry3d, rather than an Into<Isometry3d>. This removes the single item limiting Bounded3d from being dyn-compatible.

Testing

• Compiled bevy
• Compiled and ran a small example.

Alternative

As an alternative, a new dyn-compatible trait can be created, with a blanket implementation for Bounded3d. This requires no code change from other implementations of Bounded3d to change their signature.

pub trait Bounded3dDyn {
    /// Get an axis-aligned bounding box for the shape translated and rotated by the given isometry.
    fn aabb_3d_dyn(&self, isometry: bevy_::Isometry3d) -> Aabb3d;
    /// Get a bounding sphere for the shape translated and rotated by the given isometry.
    fn bounding_sphere_dyn(&self, isometry: bevy_::Isometry3d) -> BoundingSphere;
}

impl<T: Bounded3d> Bounded3dDyn for T {
    /// Get an axis-aligned bounding box for the shape translated and rotated by the given isometry.
    fn aabb_3d_dyn(&self, isometry: Isometry3d) -> Aabb3d {
        self.aabb_3d(isometry)
    }
    /// Get a bounding sphere for the shape translated and rotated by the given isometry.
    fn bounding_sphere_dyn(&self, isometry: Isometry3d) -> BoundingSphere {
        self.bounding_sphere(isometry)
    }
}

Related: #19491