Draft
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently, in scenes, resources are stored like this:
Since resources-as-components (#20934), it has become possible to attach other components to the resource entities. This is very useful for networking and something we want to support. Currently, however, the scene format does not support additional components in the format. This means that this data will be lost when converting a world to a scene and back to a world. This loss can be a pain for people working with resources.
Solution
Since resources are already stored on entities, this PR removes
resources: { ... }and instead everything is done on the entity level:Testing
TODO: Add a test, for what happens when a resource is loaded from a scene twice. What should that even do?