Skip to content

rename gltf_render_enabled to gltf_enable_standard_materials#22944

Open
ChristopherBiscardi wants to merge 1 commit intobevyengine:mainfrom
ChristopherBiscardi:gltf_render_enabled
Open

rename gltf_render_enabled to gltf_enable_standard_materials#22944
ChristopherBiscardi wants to merge 1 commit intobevyengine:mainfrom
ChristopherBiscardi:gltf_render_enabled

Conversation

@ChristopherBiscardi
Copy link
Contributor

Objective

We currently describe the new gltf_render_enabled flag as "disabling PBR rendering", which is much broader than what it does in practice. In its current form it controls the construction and insertion of StandardMaterials on entities, but does not affect the PBR rendering functionality of the application, or of glTF assets. (A user could still create their own StandardMaterials or StandardMaterial extensions and insert them on the required meshes).

Solution

Rename the flag to more accurately depict what it does in practice, which is enable/disable the automatic construction and insertion of StandardMaterials when a glTF file is loading.

Testing

There's only one example that turns this off, gltf_extension_mesh_2d, which continues to run as expected.

@ChristopherBiscardi ChristopherBiscardi added A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format labels Feb 13, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 13, 2026
@ChristopherBiscardi ChristopherBiscardi added the D-Trivial Nice and easy! A great choice to get started with Bevy label Feb 13, 2026
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is definitely better but to me the name should probably reflects a bit more that it inserts or generates something?

Something like insert_standard_material_on_gltf, gltf_insert_standard_material or something like that?

Not attached to any one in particular tbh but yeah, the current naming on main doesn't make sense to me.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 13, 2026
@AntoninD-Galadrim
Copy link

My 2 cents idea, gltf_generate_standard_materials as an alternative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-glTF Related to the glTF 3D scene/model format A-Rendering Drawing game state to the screen D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

4 participants