rename gltf_render_enabled to gltf_enable_standard_materials#22944
Open
ChristopherBiscardi wants to merge 1 commit intobevyengine:mainfrom
Open
rename gltf_render_enabled to gltf_enable_standard_materials#22944ChristopherBiscardi wants to merge 1 commit intobevyengine:mainfrom
ChristopherBiscardi wants to merge 1 commit intobevyengine:mainfrom
Conversation
IceSentry
approved these changes
Feb 13, 2026
Contributor
IceSentry
left a comment
There was a problem hiding this comment.
That one is definitely better but to me the name should probably reflects a bit more that it inserts or generates something?
Something like insert_standard_material_on_gltf, gltf_insert_standard_material or something like that?
Not attached to any one in particular tbh but yeah, the current naming on main doesn't make sense to me.
alice-i-cecile
approved these changes
Feb 13, 2026
|
My 2 cents idea, gltf_generate_standard_materials as an alternative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
We currently describe the new
gltf_render_enabledflag as "disabling PBR rendering", which is much broader than what it does in practice. In its current form it controls the construction and insertion ofStandardMaterials on entities, but does not affect the PBR rendering functionality of the application, or of glTF assets. (A user could still create their ownStandardMaterials orStandardMaterialextensions and insert them on the required meshes).Solution
Rename the flag to more accurately depict what it does in practice, which is enable/disable the automatic construction and insertion of
StandardMaterials when a glTF file is loading.Testing
There's only one example that turns this off,
gltf_extension_mesh_2d, which continues to run as expected.