Adding change_tick to deferred_world#22941
Open
andristarr wants to merge 3 commits intobevyengine:mainfrom
Open
Adding change_tick to deferred_world#22941andristarr wants to merge 3 commits intobevyengine:mainfrom
andristarr wants to merge 3 commits intobevyengine:mainfrom
Conversation
andriyDev
added
D-Trivial
andriyDev
suggested changes
Feb 13, 2026
| pub fn change_tick(self) -> Tick { | ||
| // SAFETY: | ||
| // - we only access world metadata, no structural changes happening | ||
| unsafe { self.world.world_metadata().read_change_tick() } |
Contributor
There was a problem hiding this comment.
Actually, sorry, I specifically want to avoid using read_change_tick(). We should be able to access the change tick directly without any synchronization.
andriyDev
added
S-Waiting-on-Author
|
|
||
| /// Gets the current change tick of [`DeferredWorld`]. | ||
| #[inline] | ||
| pub fn change_tick(self) -> Tick { |
Member
There was a problem hiding this comment.
This isn't going to be very useful if it consumes self completely :) You almost certainly want &self in the function argument here.
Contributor
There was a problem hiding this comment.
Wow good catch! Although, I think this should be &mut self, to match World. Since this is an AtomicU32, someone might come along and mutate this under our feet. World makes this ok since you have exclusive access to the AtomicU32, and DeferredWorld should have the same kind of access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22788
Solution
Testing
Showcase
Tickfrom deferred_world