Skip to content

Add type to conviently lookup entities by name#11842

Closed
tygyh wants to merge 1 commit into
bevyengine:mainfrom
tygyh:entity_lookup
Closed

Add type to conviently lookup entities by name#11842
tygyh wants to merge 1 commit into
bevyengine:mainfrom
tygyh:entity_lookup

Conversation

@tygyh
Copy link
Copy Markdown
Contributor

@tygyh tygyh commented Feb 13, 2024

Objective

Solution

  • Rebase and solve change conflicts.

@tygyh
Copy link
Copy Markdown
Contributor Author

tygyh commented Feb 13, 2024

When rebasing this I got stuck on which changes to take from this or #6785. I do not know who to ask for help with this.

@alice-i-cecile alice-i-cecile added A-Core A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Feb 15, 2024
@alice-i-cecile
Copy link
Copy Markdown
Member

IMO you should add only the NameLookup in this PR: it'll be easier on merge conflicts and there's a good chance that @pcwalton's plan to avoid using names to lookup animations goes through.

@tygyh
Copy link
Copy Markdown
Contributor Author

tygyh commented Feb 19, 2024

I do not see a way to implement this because of the conflicts with #6785. Since there seems to be a different solution in the works by PCWalton I will leave this on hold for now.

@IQuick143 IQuick143 added the S-Adopt-Me The original PR author has no intent to complete this work. Pick me up! label May 16, 2025
@cart cart added this to Animation Feb 12, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Animation Feb 12, 2026
@cart cart closed this May 5, 2026
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Animation May 5, 2026
@cart cart reopened this May 5, 2026
@github-project-automation github-project-automation Bot moved this from Done to Needs SME Triage in Animation May 5, 2026
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Animation May 22, 2026
@tygyh tygyh deleted the entity_lookup branch May 22, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Adopt-Me The original PR author has no intent to complete this work. Pick me up!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants