Skip to content

deps: commander upgrade #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beauraines wants to merge 5 commits into
base: main
Choose a base branch
from
Open

deps: commander upgrade #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d7699d
chore: upgrade commander to ^11.0.0
beauraines Dec 17, 2025
1792524
chore: migrate commander option syntax ([value]→<value>)
beauraines Dec 17, 2025
b0e2d33
Upgrades to commander 11.1
beauraines Dec 17, 2025
ba0a6fe
chore: use returned command from parse() and extract opts in start()
beauraines Dec 17, 2025
8408aa6
chore: extract opts from parse() in interactive mode
beauraines Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@beauraines/rtm-api": "^1.13.1",
"chalk": "^4.0.0",
"cli-table3": "^0.6.3",
"commander": "^2.11.0",
"commander": "^11.1.0",
"copy-paste": "^2.1.1",
"dateformat": "^4.0.0",
"debug": "^4.3.4",
Expand Down
12 changes: 7 additions & 5 deletions src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ function setup() {
.option('-p, --plain', 'do not use styled/colored text (overrides --color)')
.option('-c, --color', 'force the use of styled/colored text')
.option('-s, --status', 'toggle the display of the status spinner')
.option('-x, --completed [value]', 'set display of completed tasks (true/false/number of days)')
.option('-d, --hideDue [value]', 'hide tasks due more than n days from today (false/number of days)')
.option('-f, --config [file]', 'specify configuration file', function(file) {
.option('-x, --completed <value>', 'set display of completed tasks (true/false/number of days)')
.option('-d, --hideDue <value>', 'hide tasks due more than n days from today (false/number of days)')
.option('-f, --config <file>', 'specify configuration file', function(file) {
config.reset(file);
parsePlugins();
parseAliases();
Expand Down Expand Up @@ -384,7 +384,8 @@ function parseAliases() {
}

// Parse the command
global._program.parse(args);
const parsed = global._program.parse(args);
const opts = parsed.opts();

});

Expand Down Expand Up @@ -416,7 +417,8 @@ function start() {

// Parse the process arguments
else {
program.parse(process.argv);
const parsed = program.parse(process.argv);
const opts = parsed.opts();
}


Expand Down
3 changes: 2 additions & 1 deletion src/interactive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ function prompt() {

// Parse the line command with commander
else if ( commands.indexOf(cmd) > -1 || aliases.indexOf(cmd) > -1 ) {
global._program.parse(params);
const parsed = global._program.parse(params);
const opts = parsed.opts();
}

// Nothing entered
Expand Down