Skip to content

Order rust lints before clippy lints to allow ignoring unknown lints #4030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erickt wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Order rust lints before clippy lints to allow ignoring unknown lints #4030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rust/private/clippy.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,11 @@ def rust_clippy_action(ctx, clippy_executable, process_wrapper, crate_info, conf
lint_files = []
if hasattr(ctx.rule.attr, "lint_config") and ctx.rule.attr.lint_config:
clippy_flags = clippy_flags + \
ctx.rule.attr.lint_config[LintsInfo].clippy_lint_flags + \
ctx.rule.attr.lint_config[LintsInfo].rustc_lint_flags
ctx.rule.attr.lint_config[LintsInfo].rustc_lint_flags + \
ctx.rule.attr.lint_config[LintsInfo].clippy_lint_flags
lint_files = lint_files + \
ctx.rule.attr.lint_config[LintsInfo].clippy_lint_files + \
ctx.rule.attr.lint_config[LintsInfo].rustc_lint_files
ctx.rule.attr.lint_config[LintsInfo].rustc_lint_files + \
ctx.rule.attr.lint_config[LintsInfo].clippy_lint_files

compile_inputs, out_dir, build_env_files, build_flags_files, linkstamp_outs, ambiguous_libs = collect_inputs(
ctx,
Expand Down