Order rust lints before clippy lints to allow ignoring unknown lints#4030
Open
erickt wants to merge 1 commit into
Open
Order rust lints before clippy lints to allow ignoring unknown lints#4030erickt wants to merge 1 commit into
erickt wants to merge 1 commit into
Conversation
When updating the Rust toolchain in a quickly moving repository, it can be difficult to atomically fix all the lints and update the toolchain in a single commit. It can be helpful to: * land a patch that adds the flags `-Aunknown_lints -Aclippy::useless_borrows_in_formatting`. Rust needs them in that order, otherwise it will error out. * land the toolchain update. * clean up the remaining lint failures. Unfortunately before this patch rules_rust would emit the clippy lints first, then the rustc lints, so we couldn't use this pattern. This patch reverses the order and fixes this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating the Rust toolchain in a quickly moving repository, it can be difficult to atomically fix all the lints and update the toolchain in a single commit. It can be helpful to:
-Aunknown_lints -Aclippy::useless_borrows_in_formatting. Rust needs them in that order, otherwise it will error out.Unfortunately before this patch rules_rust would emit the clippy lints first, then the rustc lints, so we couldn't use this pattern. This patch reverses the order and fixes this issue.