Skip to content

fixes for model builder #5625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshuatowner wants to merge 2 commits into
base: master
Choose a base branch
from
+400 −120
Draft

fixes for model builder #5625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6004e8b
fixes for model builder
jjtowner Mar 13, 2026
e0c912b
add nova model support
jjtowner Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-core/src/sagemaker/core/shapes/shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8577,7 +8577,7 @@ class InferenceComponentComputeResourceRequirements(Base):
max_memory_required_in_mb: The maximum MB of memory to allocate to run a model that you assign to an inference component.
"""

min_memory_required_in_mb: int
min_memory_required_in_mb: Optional[int] = Unassigned()
Copy link
Contributor

@nargokul nargokul Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for this to work ?
My only concern is that this is auto-generated and it would be overriden at some point . We would need to update the engine.

Copy link
Author

@joshuatowner joshuatowner Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should sort out where this is coming from under the hood, i did get errors describing the endpoint without it

number_of_cpu_cores_required: Optional[float] = Unassigned()
number_of_accelerator_devices_required: Optional[float] = Unassigned()
max_memory_required_in_mb: Optional[int] = Unassigned()
Expand Down
Loading
Loading