Draft
Conversation
joshuatowner
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
nargokul
reviewed
Mar 13, 2026
| """ | ||
|
|
||
| min_memory_required_in_mb: int | ||
| min_memory_required_in_mb: Optional[int] = Unassigned() |
Contributor
There was a problem hiding this comment.
Is this required for this to work ?
My only concern is that this is auto-generated and it would be overriden at some point . We would need to update the engine.
Author
There was a problem hiding this comment.
we should sort out where this is coming from under the hood, i did get errors describing the endpoint without it
nargokul
reviewed
Mar 13, 2026
Comment on lines
+961
to
+962
| if not self.env_vars: | ||
| self.env_vars = config.get("Environment", {}) |
Contributor
There was a problem hiding this comment.
If it does exist, should these be appended ?
Author
There was a problem hiding this comment.
guessing yes, we should fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.