Skip to content

Fix broken default.com test case in targeted-cache-control #13081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskit merged 2 commits into from
Apr 10, 2026
+35 −1
Merged

Fix broken default.com test case in targeted-cache-control #13081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8a14ff
Fix broken default.com test case in targeted-cache-control
maskit Apr 9, 2026
eb7ef6c
Fix the fix
maskit Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 35 additions & 1 deletion tests/gold_tests/cache/replay/targeted-cache-control.replay.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ autest:
args:
- "proxy.config.http.cache.targeted_cache_control_headers=ACME-Cache-Control"

- from: "http://default.com/"
to: "http://backend.default.com:{SERVER_HTTP_PORT}/"


sessions:
- transactions:
Expand Down Expand Up @@ -246,6 +249,36 @@ sessions:
- [ Cache-Control, { value: "max-age=3600", as: equal } ]
- [ ACME-Cache-Control, { value: "no-store", as: equal } ]

#############################################################################
# Test 7: Global targeted headers apply without conf_remap override
#############################################################################
- client-request:
method: GET
url: /default/test1
version: '1.1'
headers:
fields:
- [Host, default.com]
- [uuid, default-test1-request1]

server-response:
status: 200
reason: OK
headers:
fields:
- [Content-Type, text/plain]
- [Content-Length, "14"]
- [Cache-Control, "no-store"]
- [CDN-Cache-Control, "max-age=30"]
- [Connection, close]

proxy-response:
status: 200
headers:
fields:
- [ Cache-Control, { value: "no-store", as: equal } ]
- [ CDN-Cache-Control, { value: "max-age=30", as: equal } ]

#############################################################################
# Now verify the correct cache behavior from above.
#############################################################################
Expand All @@ -266,7 +299,8 @@ sessions:
status: 404
reason: Not Found

# Expect the cached 200 response due to default CDN-Cache-Control handling.
# Expect the cached 200 response because the global config sets
# CDN-Cache-Control as a targeted header, overriding Cache-Control: no-store.
proxy-response:
status: 200
headers:
Expand Down