Fix broken default.com test case in targeted-cache-control#13081
Open
maskit wants to merge 2 commits intoapache:10.2.xfrom
Open
Fix broken default.com test case in targeted-cache-control#13081maskit wants to merge 2 commits intoapache:10.2.xfrom
maskit wants to merge 2 commits intoapache:10.2.xfrom
Conversation
- Fix the default.com test case in targeted-cache-control.replay.yaml that was broken by the cherry-pick of apache#13054 - The original commit on master (67b96e5) added both the default.com remap rule, a priming request, and the verification request — but that commit was not cherry-picked to 10.2.x because the default targeted header change was considered a breaking change - When apache#13054 was cherry-picked, it brought only the verification block without the remap rule or priming request, causing the test to always fail - Add the default.com remap rule and priming request, and update the verification to expect a cache miss — on 10.2.x the default is no targeted headers, so Cache-Control: no-store should prevent caching even with CDN-Cache-Control: max-age=30 present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the default targeted header change was considered a breaking change
override
#13080 failed because of the issue.