Skip to content

fix: convert BubbleChart boolean field to Python-compatible value #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuang7 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: convert BubbleChart boolean field to Python-compatible value #4238

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e5e0ccb
update.
xuang7 Feb 25, 2026
63a92fe
Merge branch 'main' into fix/bubble-chart-boolean-python-conversion
carloea2 Feb 26, 2026
9e747c8
update..
xuang7 Feb 26, 2026
6c2ad57
Merge remote-tracking branch 'origin/fix/bubble-chart-boolean-python-…
xuang7 Feb 26, 2026
4bdba0b
Merge branch 'main' into fix/bubble-chart-boolean-python-conversion
xuang7 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../scala/org/apache/texera/amber/operator/visualization/bubbleChart/BubbleChartOpDesc.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class BubbleChartOpDesc extends PythonOperatorDescriptor {
def createPlotlyFigure(): PythonTemplateBuilder = {
assert(xValue.nonEmpty && yValue.nonEmpty && zValue.nonEmpty)
pyb"""
| if $enableColor == 'true':
Copy link
Contributor

@carloea2 carloea2 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just if '$enableColor' == 'true':?

Copy link
Contributor Author

@xuang7 xuang7 Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. I chose this approach to stay consistent with how other operator's boolean values are handled. Since the original code already uses the string comparison style, We could go with the one-line fix.

| if '$enableColor' == 'true':
| fig = go.Figure(px.scatter(table, x=$xValue, y=$yValue, size=$zValue, size_max=100, color=$colorCategory))
| else:
| fig = go.Figure(px.scatter(table, x=$xValue, y=$yValue, size=$zValue, size_max=100))
Expand Down