fix: convert BubbleChart boolean field to Python-compatible value#4238
Open
xuang7 wants to merge 5 commits intoapache:mainfrom
Open
fix: convert BubbleChart boolean field to Python-compatible value#4238xuang7 wants to merge 5 commits intoapache:mainfrom
xuang7 wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
|
I think the best solution is to keep the previous semantics but fixing it. |
carloea2
suggested changes
Feb 26, 2026
| isColorEnabled = "True" | ||
|
|
||
| pyb""" | ||
| | if $enableColor == 'true': |
Contributor
There was a problem hiding this comment.
Why not just if '$enableColor' == 'true':?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. I chose this approach to stay consistent with how other operator's boolean values are handled. Since the original code already uses the string comparison style, We could go with the one-line fix.
…conversion' into fix/bubble-chart-boolean-python-conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds an explicit boolean conversion in BubbleChartOpDesc. It fixes an issue where the Scala boolean field enableColor was rendered in the new Python template as lowercase true/false instead of True/False. This caused a runtime error: NameError: name 'false' is not defined.
Demo:
Any related issues, documentation, discussions?
No
How was this PR tested?
Manually tested
Was this PR authored or co-authored using generative AI tooling?
No