Skip to content

Fix stale log messages, missing log args, and inconsistent metric scopes #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rzo1 merged 1 commit into from
Apr 7, 2026
Merged

Fix stale log messages, missing log args, and inconsistent metric scopes #1871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...pensearch/src/main/java/org/apache/stormcrawler/opensearch/metrics/StatusMetricsBolt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void prepare(
try {
connection = OpenSearchConnection.getConnection(stormConf, OSBoltType);
} catch (Exception e1) {
LOG.error("Can't connect to ElasticSearch", e1);
LOG.error("Can't connect to OpenSearch", e1);
throw new RuntimeException(e1);
}

Expand Down
2 changes: 1 addition & 1 deletion ...pensearch/src/main/java/org/apache/stormcrawler/opensearch/persistence/AbstractSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public void open(
client = OpenSearchConnection.getClient(stormConf, OSBoltType);
}
} catch (Exception e1) {
LOG.error("Can't connect to ElasticSearch", e1);
LOG.error("Can't connect to OpenSearch", e1);
throw new RuntimeException(e1);
}

Expand Down
8 changes: 4 additions & 4 deletions ...search/src/main/java/org/apache/stormcrawler/opensearch/persistence/AggregationSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ protected void populateBuffer() {
// dump query to log
LOG.debug("{} OpenSearch query {}", logIdprefix, request);

LOG.trace("{} isInquery set to true");
LOG.trace("{} isInQuery set to true", logIdprefix);
isInQuery.set(true);
client.searchAsync(request, RequestOptions.DEFAULT, this);
}
Expand Down Expand Up @@ -284,7 +284,7 @@ public void onResponse(SearchResponse response) {
numhits += hitsForThisBucket;

LOG.debug(
"{} key [{}], hits[{}], doc_count [{}]",
"{} key [{}], hits[{}], doc_count [{}], already_processed [{}]",
logIdprefix,
key,
hitsForThisBucket,
Expand All @@ -303,8 +303,8 @@ public void onResponse(SearchResponse response) {

queryTimes.addMeasurement(timeTaken);
eventCounter.scope("already_being_processed").incrBy(alreadyprocessed);
eventCounter.scope("ES_queries").incrBy(1);
eventCounter.scope("ES_docs").incrBy(numhits);
eventCounter.scope("OpenSearch_queries").incrBy(1);
eventCounter.scope("OpenSearch_docs").incrBy(numhits);

// optimise the nextFetchDate by getting the most recent value
// returned in the query and add to it, unless the previous value is
Expand Down