Fix stale log messages, missing log args, and inconsistent metric scopes#1871
Merged
Fix stale log messages, missing log args, and inconsistent metric scopes#1871
Conversation
- Fix "ElasticSearch" -> "OpenSearch" in error messages in AbstractSpout and StatusMetricsBolt - Fix LOG.debug in AggregationSpout.onResponse with 5 args for 4 placeholders (alreadyprocessed was silently dropped) - Fix LOG.trace missing logIdprefix argument in AggregationSpout - Rename metric scopes "ES_queries"/"ES_docs" to "OpenSearch_queries"/"OpenSearch_docs" for consistency with HybridSpout Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractSpoutandStatusMetricsBoltLOG.debuginAggregationSpout.onResponsethat had 5 arguments for 4 placeholders (alreadyprocessedwas silently dropped) — added missing placeholderLOG.traceinAggregationSpout.populateBufferthat had{}placeholder but no argument — addedlogIdprefixES_queries/ES_docstoOpenSearch_queries/OpenSearch_docsinAggregationSpoutfor consistency withHybridSpoutTest plan
mvn compile -pl external/opensearch -am— clean compilemvn checkstyle:check -pl external/opensearch— 0 violations🤖 Generated with Claude Code