Skip to content

SLING-13071 - HTL use objects that adapt from the javax SlingHttpServletRequest cannot be instantiated a Jakarta context #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rombert merged 3 commits into from
Feb 11, 2026
+27 −1
Merged

SLING-13071 - HTL use objects that adapt from the javax SlingHttpServletRequest cannot be instantiated a Jakarta context #68

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b91912c
SLING-13071 - HTL use objects that adapt from the javax SlingHttpServ…
rombert Jan 23, 2026
59de2f8
SLING-13071 - HTL use objects that adapt from the javax SlingHttpServ…
rombert Feb 2, 2026
124c866
SLING-13071 - HTL use objects that adapt from the javax SlingHttpServ…
rombert Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/main/java/org/apache/sling/engine/impl/SlingRequestProcessorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import org.apache.sling.api.SlingException;
import org.apache.sling.api.SlingHttpServletRequest;
import org.apache.sling.api.SlingJakartaHttpServletRequest;
import org.apache.sling.api.SlingJakartaHttpServletResponse;
import org.apache.sling.api.SlingServletException;
Expand All @@ -51,6 +52,7 @@
import org.apache.sling.api.servlets.ErrorHandler;
import org.apache.sling.api.servlets.JakartaErrorHandler;
import org.apache.sling.api.servlets.ServletResolver;
import org.apache.sling.api.wrappers.JakartaToJavaxRequestWrapper;
import org.apache.sling.api.wrappers.JavaxToJakartaRequestWrapper;
import org.apache.sling.api.wrappers.JavaxToJakartaResponseWrapper;
import org.apache.sling.api.wrappers.SlingJakartaHttpServletResponseWrapper;
Expand Down Expand Up @@ -202,10 +204,34 @@ public List<StaticResponseHeader> getAdditionalResponseHeaders() {
return this.additionalResponseHeaders;
}

@SuppressWarnings("deprecation")
public <Type> Type adaptTo(Object object, Class<Type> type) {
final AdapterManager adapterManager = this.adapterManager;
if (adapterManager != null) {
return adapterManager.getAdapter(object, type);

// After the migration to the Jakarta Servlet API we need to insure backwards compatibility for adapters
// registered for the legacy javax.servlet request and response objects

// 1. Try adaptables registered explicitly for the type - expected to be SlingJakartaHttpServletRequest and
// SlingJakartaHttpServletResponse
Type adapted = adapterManager.getAdapter(object, type);
if (adapted != null) return adapted;
// 2. In case of no adapters being found introspect the adaptable and adjust

// 2a. adapt jakarta request to legacy javax
if (object instanceof SlingJakartaHttpServletRequest request) {

SlingHttpServletRequest legacy = JakartaToJavaxRequestWrapper.toJavaxRequest(request);

// 2a. Direct adaption to a javax request
// One scenario where this happens is when a Sling Model is adapted from the request and has it injected
// as @Self with the type of SlingHttpServletRequest
if (type == SlingHttpServletRequest.class) return type.cast(legacy);

// 2b. consult the adapters registered for the javax request and return the result. No other fallback is
// needed
return adapterManager.getAdapter(legacy, type);
}
}

// no adapter manager, nothing to adapt to
Expand Down