SLING-13071 - HTL use objects that adapt from the javax SlingHttpServletRequest cannot be instantiated a Jakarta context #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letRequest cannot be instantiated a Jakarta context Implement a fallback for adapting from the legacy javax servlet requerst when adapting from the jakarta request fails. Adapters are normally expected to be registered for the legacy javax.servlet-based APIs and we need the adaptions to keep working for backwards compatibility.
Contributor
Author
|
This seems to fix the problem but needs more testing. At a minimum we will need to implement the same fallback for the response object. |
|
Member
|
Shouldn't this kind of fallback rather be implemented in Sling Models (i.e. register the Model for both servlet request types). Having this for all kind of adaptations feels too magic to me. |
Contributor
Author
|
I don't think this has to do with models, that is a different problem that also needs to be handled, according to my tests
See apache/sling-org-apache-sling-starter-test-services#20 and the IT pull request linked from there for details.
And this is very likely unrelated to HTL but that was the scenario where I discovered the problem.
…On January 24, 2026 2:26:14 PM GMT+01:00, Konrad Windszus ***@***.***> wrote:
kwin left a comment (apache/sling-org-apache-sling-engine#68)
Shouldn't this kind of fallback rather be implemented in Sling Models (i.e. register the Model for both servlet request types). Having this for all kind of adaptations feels too magic to me.
--
Reply to this email directly or view it on GitHub:
#68 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a fallback for adapting from the legacy javax servlet requerst when adapting from the jakarta request fails.
Adapters are normally expected to be registered for the legacy javax.servlet-based APIs and we need the adaptions to keep working for backwards compatibility.