Skip to content

[improve][broker] Enhance advertised address resolution with fallback to localhost #25238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodece merged 2 commits into from
Feb 12, 2026
Merged

[improve][broker] Enhance advertised address resolution with fallback to localhost #25238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98e37d
[improve][broker] Enhance advertised address resolution with fallback…
nodece Feb 10, 2026
52f429d
Use localhost as the advertised address for testing
nodece Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandaloneStarter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.commons.lang3.StringUtils;
import org.apache.logging.log4j.LogManager;
import org.apache.pulsar.broker.ServiceConfiguration;
import org.apache.pulsar.broker.ServiceConfigurationUtils;
import org.apache.pulsar.common.configuration.PulsarConfigurationLoader;
import org.apache.pulsar.docs.tools.CmdGenerateDocs;
import picocli.CommandLine;
Expand Down Expand Up @@ -91,8 +92,12 @@ public PulsarStandaloneStarter(String[] args) throws Exception {
// Use advertised address from command line
config.setAdvertisedAddress(this.getAdvertisedAddress());
} else if (isBlank(config.getAdvertisedAddress()) && isBlank(config.getAdvertisedListeners())) {
// Use advertised address as local hostname
config.setAdvertisedAddress("localhost");
try {
config.setAdvertisedAddress(ServiceConfigurationUtils.unsafeLocalhostResolve());
} catch (Exception e) {
log.warn("Failed to resolve FQDN, using 'localhost' as advertised address", e);
config.setAdvertisedAddress("localhost");
}
} else {
// Use advertised or advertisedListeners address from config file
}
Expand Down
2 changes: 1 addition & 1 deletion tests/bc_2_0_0/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
2 changes: 1 addition & 1 deletion tests/bc_2_0_1/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
2 changes: 1 addition & 1 deletion tests/bc_2_6_0/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
2 changes: 1 addition & 1 deletion ...ion/src/test/java/org/apache/pulsar/tests/integration/containers/StandaloneContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public StandaloneContainer(String clusterName, String pulsarImageName) {
@Override
protected void configure() {
super.configure();
setCommand("standalone");
setCommand("standalone --advertised-address localhost");
addEnv("PULSAR_MEM", "-Xms128M -Xmx1g -XX:MaxDirectMemorySize=1g");
}

Expand Down
2 changes: 1 addition & 1 deletion ...t-admin-shade-test/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
2 changes: 1 addition & 1 deletion ...ent-all-shade-test/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
2 changes: 1 addition & 1 deletion ...-client-shade-test/src/test/java/org/apache/pulsar/tests/integration/PulsarContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public PulsarContainer() {
public PulsarContainer(final String pulsarVersion) {
super(pulsarVersion);
withExposedPorts(BROKER_HTTP_PORT, PULSAR_PORT);
withCommand("/pulsar/bin/pulsar standalone");
withCommand("/pulsar/bin/pulsar standalone --advertised-address localhost");
waitingFor(new HttpWaitStrategy()
.forPort(BROKER_HTTP_PORT)
.forStatusCode(200)
Expand Down
Loading