Skip to content

[improve][broker] Enhance advertised address resolution with fallback to localhost #25238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodece merged 2 commits into from
Feb 12, 2026
Merged

[improve][broker] Enhance advertised address resolution with fallback to localhost #25238

nodece merged 2 commits into from
Feb 12, 2026
+14 −9

Conversation

@nodece
Copy link
Member

@nodece nodece commented Feb 11, 2026 •
edited
Loading

Motivation

Currently, in standalone mode, the broker uses localhost as the advertised address (as seen in #5856), which works fine for local testing. However, in Kubernetes deployments, this behavior can be problematic: clients connecting via Pulsar Proxy attempt to reach localhost:6550, which is incorrect in a podized environment.

Modifications

  • Prefer the broker's fully qualified domain name (FQDN) as the advertised address in the standalone model
  • Fallback to localhost only if FQDN resolution fails
  • Make the standalone test with --advertised-adress localhost

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@nodece nodece requested review from dao-jun and lhotari February 11, 2026 07:06
@nodece nodece self-assigned this Feb 11, 2026
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 11, 2026
lhotari
lhotari approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari added this to the 4.2.0 milestone Feb 11, 2026
@nodece nodece merged commit 1db61ac into apache:master Feb 12, 2026
103 of 106 checks passed
@nodece nodece deleted the fix-advertisedAddress branch February 12, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhotari lhotari lhotari approved these changes

@dao-jun dao-jun Awaiting requested review from dao-jun

Assignees

@nodece nodece

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@nodece @lhotari