Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,12 @@
isAligned =
((header.getChunkType() & TsFileConstant.TIME_COLUMN_MASK)
== TsFileConstant.TIME_COLUMN_MASK);
if (isAligned) {
pageIndex2Times = new HashMap<>();
pageIndex2ChunkData = new HashMap<>();
isTimeChunkNeedDecode = true;
}

IChunkMetadata chunkMetadata = offset2ChunkMetadata.get(chunkOffset - Byte.BYTES);
// When loading TsFile with Chunk in data zone but no matched ChunkMetadata
// at the end of file, this Chunk needs to be skipped.
Expand Down Expand Up @@ -195,7 +201,7 @@
decodeAndWriteTimeChunkOrNonAlignedChunk(reader, header, chunkMetadata, chunkOffset, chunkData);
}

private void decodeAndWriteTimeChunkOrNonAlignedChunk(

Check warning on line 204 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/TsFileSplitter.java

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

A "Brain Method" was detected. Refactor it to reduce at least one of the following metrics: LOC from 89 to 64, Complexity from 16 to 14, Nesting Level from 6 to 2, Number of Variables from 25 to 6.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AZ4LDEKNL6Zq06p1ao15&open=AZ4LDEKNL6Zq06p1ao15&pullRequest=17625
TsFileSequenceReader reader,
ChunkHeader header,
IChunkMetadata chunkMetadata,
Expand Down Expand Up @@ -359,9 +365,6 @@
pageIndex2TimesList.add(pageIndex2Times);
pageIndex2ChunkDataList.add(pageIndex2ChunkData);
isTimeChunkNeedDecodeList.add(isTimeChunkNeedDecode);
pageIndex2Times = new HashMap<>();
pageIndex2ChunkData = new HashMap<>();
isTimeChunkNeedDecode = true;
}

private void switchToTimeChunkContextOfCurrentMeasurement(
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,157 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.apache.iotdb.db.storageengine.load.splitter;

import org.apache.tsfile.enums.ColumnCategory;
import org.apache.tsfile.enums.TSDataType;
import org.apache.tsfile.file.metadata.AbstractAlignedChunkMetadata;
import org.apache.tsfile.file.metadata.IDeviceID;
import org.apache.tsfile.file.metadata.StringArrayDeviceID;
import org.apache.tsfile.file.metadata.TableSchema;
import org.apache.tsfile.read.TsFileSequenceReader;
import org.apache.tsfile.write.chunk.AlignedChunkWriterImpl;
import org.apache.tsfile.write.schema.IMeasurementSchema;
import org.apache.tsfile.write.schema.MeasurementSchema;
import org.apache.tsfile.write.schema.Schema;
import org.apache.tsfile.write.writer.TsFileIOWriter;
import org.junit.Assert;
import org.junit.Test;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.DataOutputStream;
import java.io.File;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import java.util.Objects;

public class TsFileSplitterTest {

@Test
public void testSplitTableTimeOnlyAlignedChunk() throws Exception {
final File sourceTsFile = new File("split-table-time-only-source.tsfile");
final File targetTsFile = new File("split-table-time-only-target.tsfile");
final IDeviceID deviceID = new StringArrayDeviceID("table1", "tagA");

try {
writeTableTsFileWithTimeOnlyChunk(sourceTsFile, deviceID);

final List<ChunkData> emittedChunkDataList = new ArrayList<>();
final TsFileSplitter splitter =
new TsFileSplitter(
sourceTsFile,
tsFileData -> {
if (tsFileData instanceof ChunkData) {
emittedChunkDataList.add((ChunkData) tsFileData);
}
return true;
});
splitter.splitTsFileByDataPartition();

if (targetTsFile.exists()) {
Assert.assertTrue(targetTsFile.delete());
}
try (final TsFileIOWriter writer = new TsFileIOWriter(targetTsFile)) {
writer.setSchema(createSchema());
IDeviceID currentDeviceID = null;
for (final ChunkData chunkData : emittedChunkDataList) {
if (!Objects.equals(currentDeviceID, chunkData.getDevice())) {
if (Objects.nonNull(currentDeviceID)) {
writer.endChunkGroup();
}
writer.startChunkGroup(chunkData.getDevice());
currentDeviceID = chunkData.getDevice();
}

writeSerializedChunkDataToWriter(chunkData, writer);
}
if (Objects.nonNull(currentDeviceID)) {
writer.endChunkGroup();
}
writer.endFile();
}

Assert.assertEquals(1, emittedChunkDataList.size());
try (final TsFileSequenceReader reader =
new TsFileSequenceReader(targetTsFile.getAbsolutePath())) {
final List<AbstractAlignedChunkMetadata> chunkMetadataList =
reader.getAlignedChunkMetadata(deviceID, false);
Assert.assertEquals(1, chunkMetadataList.size());
Assert.assertEquals(
2, chunkMetadataList.get(0).getTimeChunkMetadata().getStatistics().getCount());
Assert.assertTrue(chunkMetadataList.get(0).getValueChunkMetadataList().isEmpty());
}
} finally {
if (sourceTsFile.exists()) {
Assert.assertTrue(sourceTsFile.delete());
}
if (targetTsFile.exists()) {
Assert.assertTrue(targetTsFile.delete());
}
}
}

private void writeTableTsFileWithTimeOnlyChunk(final File tsFile, final IDeviceID deviceID)
throws Exception {
if (tsFile.exists()) {
Assert.assertTrue(tsFile.delete());
}

try (final TsFileIOWriter writer = new TsFileIOWriter(tsFile)) {
writer.setSchema(createSchema());
writer.startChunkGroup(deviceID);

final AlignedChunkWriterImpl chunkWriter =
new AlignedChunkWriterImpl(Collections.emptyList());
chunkWriter.write(100);
chunkWriter.write(101);
chunkWriter.writeToFileWriter(writer);

writer.endChunkGroup();
writer.endFile();
}
}

private Schema createSchema() {
final List<IMeasurementSchema> tableSchemaList =
Arrays.asList(
new MeasurementSchema("tag1", TSDataType.STRING),
new MeasurementSchema("s1", TSDataType.INT64));
final List<ColumnCategory> columnCategoryList =
Arrays.asList(ColumnCategory.TAG, ColumnCategory.FIELD);

final Schema schema = new Schema();
schema.registerTableSchema(new TableSchema("table1", tableSchemaList, columnCategoryList));
return schema;
}

private void writeSerializedChunkDataToWriter(
final ChunkData chunkData, final TsFileIOWriter writer) throws Exception {
final ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream();
try (final DataOutputStream dataOutputStream = new DataOutputStream(byteArrayOutputStream)) {
chunkData.serialize(dataOutputStream);
}
((ChunkData)
TsFileData.deserialize(new ByteArrayInputStream(byteArrayOutputStream.toByteArray())))
.writeToFileWriter(writer);
}
}
Loading