Skip to content

Fix that load tsfile may skip time-only aligned chunks#17625

Open
jt2594838 wants to merge 1 commit intomasterfrom
fix_load_time_only_chunk
Open

Fix that load tsfile may skip time-only aligned chunks#17625
jt2594838 wants to merge 1 commit intomasterfrom
fix_load_time_only_chunk

Conversation

@jt2594838
Copy link
Copy Markdown
Contributor

For time-only aligned chunk:

  1. the current pageIndex2ChunkData is cleared after calling storeTimeChunkContext;
  2. pageIndex2ChunkData will not be set restored becauses there is no value chunk to call switchToTimeChunkContextOfCurrentMeasurement

The result is that the time-only chunk is ignored because pageIndex2ChunkData is empty.

In this PR, the pageIndex2ChunkData is not cleared in storeTimeChunkContext, but a new one is created in processTimeChunkOrNonAlignedChunk.
Therefore, when calling consumeAllAlignedChunkData, the time-only chunk is still preserved.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.24%. Comparing base (acaabb8) to head (ce979f2).
⚠️ Report is 53 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17625      +/-   ##
============================================
+ Coverage     39.80%   40.24%   +0.43%     
- Complexity      312     2554    +2242     
============================================
  Files          5142     5177      +35     
  Lines        347882   348881     +999     
  Branches      44404    44625     +221     
============================================
+ Hits         138489   140391    +1902     
+ Misses       209393   208490     -903     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants