Skip to content

Issue with Mounting Certificate from ConfigMap in Grafana #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianFehlinger wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue with Mounting Certificate from ConfigMap in Grafana #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deca062
fix: add option for Grafana server volumes
ChristianFehlinger Jan 22, 2025
8384a71
fix: use extraVolumes instead of extraVolumeMounts
ChristianFehlinger Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions charts/devlake/charts/grafana/templates/_pod.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,17 +1134,20 @@ volumes:
{{- toYaml .csi | nindent 6 }}
{{- end }}
{{- end }}
{{- range .Values.extraVolumeMounts }}
{{- range .Values.extraVolumes }}
- name: {{ .name }}
{{- if .existingClaim }}
persistentVolumeClaim:
claimName: {{ .existingClaim }}
{{- else if .hostPath }}
hostPath:
path: {{ .hostPath }}
{{ toYaml .hostPath | nindent 6 }}
Copy link
Contributor

@JorgeGar JorgeGar Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change also related to the issue with the volume mount?

{{- else if .csi }}
csi:
{{- toYaml .data | nindent 6 }}
{{- else if .configMap }}
configMap:
{{- toYaml .configMap | nindent 6 }}
Copy link
Contributor

@JorgeGar JorgeGar Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as before 😅

{{- else }}
emptyDir: {}
{{- end }}
Expand Down
16 changes: 16 additions & 0 deletions charts/devlake/charts/grafana/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,22 @@ extraSecretMounts: []
# nodePublishSecretRef: # Only required when using service principal mode
# name: grafana-akv-creds # Only required when using service principal mode

## Additional Grafana server volumes
extraVolumes: []
# - name: extra-volume-0
# existingClaim: volume-claim
# - name: extra-volume-1
# hostPath:
# path: /usr/shared/
# type: ""
# - name: grafana-secrets
# csi:
# driver: secrets-store.csi.k8s.io
# readOnly: true
# volumeAttributes:
# secretProviderClass: "grafana-env-spc"


## Additional grafana server volume mounts
# Defines additional volume mounts.
extraVolumeMounts: []
Expand Down