Issue with Mounting Certificate from ConfigMap in Grafana #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrong variable was used
Contributor
JorgeGar
reviewed
Feb 25, 2025
| {{- else if .hostPath }} | ||
| hostPath: | ||
| path: {{ .hostPath }} | ||
| {{ toYaml .hostPath | nindent 6 }} |
Contributor
There was a problem hiding this comment.
Is this change also related to the issue with the volume mount?
| {{- toYaml .data | nindent 6 }} | ||
| {{- else if .configMap }} | ||
| configMap: | ||
| {{- toYaml .configMap | nindent 6 }} |
Contributor
There was a problem hiding this comment.
Same question as before 😅
Contributor
|
An alternative solution is using the latest helm chart version - see #346 |
Contributor
|
this should be fixed now, could you please re-test? |
Contributor
|
@jekader Please fix the conflicts so I can run the tests. |
Contributor
|
@klesh this PR is no longer relevant since we bumped the grafana chart to a fixed version |
Contributor
|
Hi @jekader, thanks for the information! Would you be interested in becoming an Apache Committer for this project? If so, feel free to reach out to me on Slack — I’d be more than happy to introduce you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis
The issue seems to be caused by the Grafana version being a bit older. Specifically, the problem originates from this line of code:
This issue appears to have been addressed in this issue in the grafana community Helm charts.
Solution
Fix the issue in the current Grafana version by modifying the template.
related to issue 319