Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,21 +1,3 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
package org.apache.fineract.infrastructure.core.service;

import static org.junit.jupiter.api.Assertions.assertEquals;
Expand All @@ -34,14 +16,14 @@ void clearContext() {
RequestContextHolder.resetRequestAttributes();
}

// Proper isolation helper
// Helper method for setting request context
private void withRequest(HttpServletRequest request, Runnable testLogic) {
ServletRequestAttributes attributes = new ServletRequestAttributes(request);
try {
RequestContextHolder.setRequestAttributes(attributes);
testLogic.run();
} finally {
RequestContextHolder.resetRequestAttributes(); // critical cleanup
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Pr does not add any unit tests,

RequestContextHolder.resetRequestAttributes();
}
}

Expand Down Expand Up @@ -86,4 +68,4 @@ void getClientIpConvertsNonStringAttributeUsingToString() {
assertEquals("12345", result);
});
}
}
}
Loading