FINERACT-5707: Add unit tests for MathUtil#5707
Open
shleshaG wants to merge 1 commit intoapache:developfrom
Open
FINERACT-5707: Add unit tests for MathUtil#5707shleshaG wants to merge 1 commit intoapache:developfrom
shleshaG wants to merge 1 commit intoapache:developfrom
Conversation
Aman-Mittal
requested changes
Mar 28, 2026
Contributor
Aman-Mittal
left a comment
Aman-Mittal
left a comment
There was a problem hiding this comment.
@shleshaG Are you sure this PR is right one?
shleshaG
changed the title
Author
|
@Aman-Mittal Yes, thanks for pointing it out. The issue number was incorrect earlier. I have now updated the tests specifically for MathUtil under FINERACT-5707. |
Aman-Mittal
reviewed
Mar 31, 2026
| RequestContextHolder.setRequestAttributes(attributes); | ||
| testLogic.run(); | ||
| } finally { | ||
| RequestContextHolder.resetRequestAttributes(); // critical cleanup |
Contributor
There was a problem hiding this comment.
This Pr does not add any unit tests,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comprehensive unit tests for MathUtil utility class.
Covered scenarios:
All tests pass successfully.