Skip to content

Fix inverted condition in ExternalCompactionProgressIT wait for compaction start #6066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomGarguilo merged 2 commits into from
Jan 21, 2026
Merged

Fix inverted condition in ExternalCompactionProgressIT wait for compaction start #6066

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e86ce62
fix inverted condition
teamconfx Jan 17, 2026
82c6042
Apply code formatting
teamconfx Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion test/src/main/java/org/apache/accumulo/test/compaction/ExternalCompactionProgressIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,21 @@ public void testCompactionDurationContinuesAfterCoordinatorStop() throws Excepti
EnumSet.of(IteratorUtil.IteratorScope.majc));

log.info("Compacting table");

// Verify no compactions are running before we start (catch any leftover state from other
// tests)
Map<String,TExternalCompaction> initialCompactions =
getRunningCompactions(getCluster().getServerContext()).getCompactions();
assertTrue(initialCompactions == null || initialCompactions.isEmpty(),
"Expected no running compactions before starting the test");

Comment on lines +144 to +151
Copy link
Contributor

@dlmarion dlmarion Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does no harm, but not sure it's needed. The parent class, AccumuloClusterHarness, restarts MiniAccumuloCluster in between each test method (see class javadoc).

compact(client, table, 2, QUEUE1, false);

// Wait until the compaction starts
Wait.waitFor(() -> {
Map<String,TExternalCompaction> compactions =
getRunningCompactions(getCluster().getServerContext()).getCompactions();
return compactions == null || compactions.isEmpty();
return compactions != null && !compactions.isEmpty();
Copy link
Contributor

@dlmarion dlmarion Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good catch. I can see how this may have originally occurred due to copy/paste content between test methods.

}, 30_000, 100, "Compaction did not start within the expected time");

// start a timer after the compaction starts
Expand Down