Fix inverted condition in ExternalCompactionProgressIT wait for compaction start #6066
+8
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for fixing #6050.
Summary
Description
In ExternalCompactionProgressIT.testCompactionDurationContinuesAfterCoordinatorStop(), the Wait.waitFor() condition was inverted. The code comment indicated it should "Wait until the compaction starts", but the actual condition compactions == null || compactions.isEmpty() was waiting for the opposite—no compactions to be running.
Before:
After:
The test was still passing because sleepUninterruptibly(6, TimeUnit.SECONDS) followed the wait, giving enough time for the compaction to actually start. However, compactionStartTime was not
accurately reflecting when the compaction truly started.
Additionally, a pre-condition check was added to ensure no compactions are running before the test begins, which helps catch any accidental leftover state from other tests as requested in #6050.