Skip to content

test: delete e2e directories after tests finish #31839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgp1130 merged 3 commits into from
Nov 19, 2025
Merged

test: delete e2e directories after tests finish #31839

dgp1130 merged 3 commits into from
Nov 19, 2025

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 17, 2025

Deletes the e2e directories after tests complete to ensure a clean state for subsequent test runs and to free up disk space.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 17, 2025
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Nov 17, 2025
@alan-agius4 alan-agius4 requested a review from hybrist November 17, 2025 09:43
@alan-agius4
test: delete e2e directories after tests finish
abd2ba5 
Deletes the e2e directories after tests complete to ensure a clean state for subsequent test runs and to free up disk space.
@alan-agius4
Revert "ci: bump specs for e2e-package-managers"
07884eb 
This reverts commit 7217478.
@alan-agius4 alan-agius4 reopened this Nov 17, 2025
hybrist
hybrist approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@hybrist hybrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good but should we do this after the release on Wednesday, assuming that CI had been passing consistently with the larger machines? E.g. simpler mitigation while we prepare for the 21 release?

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Nov 17, 2025

SGTM @hybrist

@alan-agius4 alan-agius4 added state: blocked target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate state: blocked action: merge The PR is ready for merge by the caretaker labels Nov 17, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 19, 2025
@alan-agius4
build: clean up verdaccio storage and share storage
23a3783 
Ensures that the Verdaccio registry storage is properly cleaned up at the end of E2E tests by placing it within the main temporary directory which is now explicitly deleted on process exit or SIGINT.

This change also centralizes the Verdaccio storage location, allowing both HTTP and HTTPS Verdaccio instances to share the same storage, simplifying test setup and cleanup. Removes redundant temporary directory creation logic for npm sandbox and temporary project roots, as these are now managed by a single `tmp-root`.
@alan-agius4 alan-agius4 requested a review from hybrist November 19, 2025 13:00
@angular angular deleted a comment from ngbot bot Nov 19, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Nov 19, 2025
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2025
@ngbot
Copy link

ngbot bot commented Nov 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit 8335187 into angular:main Nov 19, 2025
33 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 20, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hybrist hybrist hybrist approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @dgp1130 @hybrist