Update core-telecom dependency and add CALL_BACK intent filter#405
Merged
yrezgui merged 5 commits intoandroid:mainfrom Apr 8, 2026
Merged
Conversation
added 3 commits
January 28, 2026 22:58
- Update `androidx.core:core-telecom` from `1.0.0-alpha02` to `1.0.1` (latest stable). - Add `android.telecom.action.CALL_BACK` intent filter to the main activity to support integrated call logging.
…ge' into telecom-integrated-call-log-change
- Update: `androidx.core:core-telecom` to `1.1.0-alpha04`. - Add: a UI option to the Telecom sample to exclude calls from the system call log using the `isLogExcluded` property in `CallAttributesCompat`. - Implement handling for `TelecomManager.ACTION_CALL_BACK` in `TelecomCallActivity` to support re-initiating calls from the system UI. - Update Android Gradle Plugin to `8.13.2` and Gradle wrapper to `8.13` to compile against 36.1. - Refactor URI creation to use the `toUri()` extension function. - Update `compileSdk` configuration and add the Foojay toolchain resolver plugin.
natarajkr007
requested review from
alabiaga,
ashnohe,
madebymozart and
yrezgui
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the project to Gradle 8.13 and Android Gradle Plugin 8.13.2, while introducing a feature to exclude calls from system logs in the Telecom sample. It also adds initial support for handling call-back intents in TelecomCallActivity. Feedback highlights the need to use intent data for call-backs instead of hardcoded URIs, the importance of overriding onNewIntent to handle activity reuse, and the removal of a stale TODO comment in the repository.
.../telecom/src/main/java/com/example/platform/connectivity/telecom/call/TelecomCallActivity.kt
Show resolved
Hide resolved
.../telecom/src/main/java/com/example/platform/connectivity/telecom/call/TelecomCallActivity.kt
Show resolved
Hide resolved
...lecom/src/main/java/com/example/platform/connectivity/telecom/model/TelecomCallRepository.kt
Outdated
Show resolved
Hide resolved
- Add `onNewIntent` to `TelecomCallActivity` to handle call-back intents when the activity is already running.
- Remove obsolete TODO regarding `isLogExcluded` in `TelecomCallRepository`.
- Add `@SuppressLint("RequiresWindowSdk")` to `ExampleWindowInitializer.create` to suppress false positive lint warning.
Change-Id: I66df7227042f72d20cd328cac16a8a802385781b
alabiaga
approved these changes
Apr 8, 2026
.../telecom/src/main/java/com/example/platform/connectivity/telecom/call/TelecomCallActivity.kt
Outdated
Show resolved
Hide resolved
yrezgui
reviewed
Apr 8, 2026
...er/src/main/java/com/example/platform/ui/windowmanager/embedding/ExampleWindowInitializer.kt
Outdated
Show resolved
Hide resolved
...ctivity/telecom/src/main/java/com/example/platform/connectivity/telecom/TelecomCallSample.kt
Outdated
Show resolved
Hide resolved
...ctivity/telecom/src/main/java/com/example/platform/connectivity/telecom/TelecomCallSample.kt
Outdated
Show resolved
Hide resolved
yrezgui
requested changes
Apr 8, 2026
…izer
- Update `launchCall` invocations to use named arguments for `excludeCallLogging` to improve readability.
- moved `@SuppressLint("RequiresWindowSdk")` annotation in `ExampleWindowInitializer` to a new PR.
Change-Id: I9e363e3c3b38ef6c840f23fe4b27df5c5d4a9d94
yrezgui
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependencies, adds new features, and refactors the Telecom sample to support excluding calls from call logs.
Dependency and Build System Updates:
8.13.2and Gradle to8.13to compile sample for 36.1Feature: Exclude Calls from Call Logs
TelecomCallServiceandTelecomCallRepositoryto accept and propagate theexcludeCallLoggingparameter, using theisLogExcludedattribute inCallAttributesCompat.Telecom Sample Enhancements
TelecomManager.ACTION_CALL_BACKintent inTelecomCallActivityto support call-back actions.