Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request downgrades Gradle and AGP versions, removes the 'Exclude from call logs' feature, and refactors the Telecom sample. Feedback focuses on maintaining the version catalog for the telecom dependency to avoid hardcoding and removing unused imports in the repository class.
| firebaseCrashlyticsBuildtools = "3.0.5" | ||
| uwb = "1.0.0-alpha10" | ||
| telecom = "1.1.0-alpha04" | ||
|
|
There was a problem hiding this comment.
Instead of removing the telecom version from the catalog, it should be updated to 1.0.1. Centralizing dependency versions in the catalog is a best practice that should be maintained even during reverts.
| telecom = "1.0.1" |
| kotlin-coroutines-play = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-play-services", version.ref = "coroutines" } | ||
| play-services-location = { module = "com.google.android.gms:play-services-location", version.ref = "play-services-location" } | ||
| androidx-core-telecom = { module = "androidx.core:core-telecom", version.ref = "telecom" } | ||
|
|
There was a problem hiding this comment.
The androidx-core-telecom library definition should remain in the version catalog to avoid hardcoding dependencies in the module-level build.gradle.kts files.
| androidx-core-telecom = { module = "androidx.core:core-telecom", version.ref = "telecom" } |
| } | ||
|
|
||
| dependencies { | ||
| implementation("androidx.core:core-telecom:1.0.1") |
There was a problem hiding this comment.
The dependency version is hardcoded here. Please use the version catalog reference instead to maintain consistency with the rest of the project.
implementation(libs.androidx.core.telecom)| import androidx.core.telecom.CallException | ||
| import androidx.core.telecom.CallsManager | ||
| import kotlinx.coroutines.CoroutineScope | ||
| import kotlinx.coroutines.Dispatchers | ||
| import kotlinx.coroutines.SupervisorJob |
There was a problem hiding this comment.
The imports for CallException, CoroutineScope, Dispatchers, and SupervisorJob are unused in this file and should be removed to keep the code clean.
| import androidx.core.telecom.CallException | |
| import androidx.core.telecom.CallsManager | |
| import kotlinx.coroutines.CoroutineScope | |
| import kotlinx.coroutines.Dispatchers | |
| import kotlinx.coroutines.SupervisorJob | |
| import androidx.core.telecom.CallsManager |
1 participant
…r (#405)"
This reverts commit 2d64c04.