Skip to content

refactor: move evaluation classes into AmplitudeAnalytics module #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FabricioFFC wants to merge 4 commits into from
Closed

refactor: move evaluation classes into AmplitudeAnalytics module #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6db8ee1
refactor: move evaluation classes into AmplitudeAnalytics module
FabricioFFC Nov 25, 2025
c571fe4
chore: fix contributing guide link
FabricioFFC Nov 25, 2025
399b9f6
refactor: remove CycleError that was duplicated and not being used
FabricioFFC Nov 25, 2025
0c2173f
update concurrent-ruby gem to support newer versions
FabricioFFC Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Please fill out the following sections to help us quickly review your pull reque

### Checklist

* [ ] Does your PR title have the correct [title format](https://github.com/amplitude/experiments-ruby-server/blob/main/CONTRIBUTING.md#pr-commit-title-conventions)?
* [ ] Does your PR title have the correct [title format](https://github.com/amplitude/experiment-ruby-server/blob/main/CONTRIBUTING.md#pr-commit-title-conventions)?
* Does your PR have a breaking change?: <!-- Yes or no -->
2 changes: 1 addition & 1 deletion amplitude-experiment.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ['lib']
spec.extra_rdoc_files = ['README.md']

spec.add_dependency 'concurrent-ruby', '~> 1.2.2'
spec.add_dependency 'concurrent-ruby', '~> 1.2'

spec.add_development_dependency 'psych', '~> 4.0'
spec.add_development_dependency 'rake', '~> 13.0'
Expand Down
14 changes: 0 additions & 14 deletions lib/experiment/error.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,4 @@ def initialize(status_code, cohort_id, message)
@status_code = status_code
end
end

class CycleError < StandardError
# Raised when topological sorting encounters a cycle between flag dependencies.
attr_reader :path

def initialize(path)
super
@path = path
end

def to_s
"Detected a cycle between flags #{@path}"
end
end
end
Loading