Skip to content

Conversation

@FabricioFFC
Copy link

@FabricioFFC FabricioFFC commented Nov 26, 2025

Summary

We're migrating to the Amplitude SDK, and during this process, we noticed that some module names (e.g., Evaluation) conflict with the third party feature-flag SDK we currently use.

This PR resolves the conflict by adding all classes and modules that were not already namespaced to the AmplitudeExperiment module.

Besides that there are some minor changes included:

  • CycleError was duplicated, so it was removed
  • The link to the CONTRIBUTING is now updated with the correct link
  • update concurrent-ruby to support newer versions

For reviewers: enabling Hide whitespace will reduce noise in the diff and make the PR easier to review. :)

Screenshot 2025-11-26 at 1 39 17 PM

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

@FabricioFFC FabricioFFC force-pushed the add-namespace-to-all-classes-modules branch from a4a4fc7 to 0c2173f Compare December 1, 2025 18:58
@kyeh-amp
Copy link
Collaborator

kyeh-amp commented Dec 3, 2025

@FabricioFFC thank you so much for bringing this up! I've used your branch to start and made some slight adjustments on your take here: #77

I hope you don't mind - I felt this would be faster than the back-and-forth.

@FabricioFFC
Copy link
Author

FabricioFFC commented Dec 3, 2025

@FabricioFFC thank you so much for bringing this up! I've used your branch to start and made some slight adjustments on your take here: #77

I hope you don't mind - I felt this would be faster than the back-and-forth.

@kyeh-amp no problem. Are you planning to include the other small changes that aren't related to the AmplitudeExperiment module as well, or should those go into a follow-up PR?

@kyeh-amp
Copy link
Collaborator

kyeh-amp commented Dec 4, 2025

This change was included in today's release of v1.7.1. Closing this now.

@kyeh-amp kyeh-amp closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants