Merged
Conversation
Contributor
stephencdaly
left a comment
stephencdaly
left a comment
There was a problem hiding this comment.
Really nice work. Just spotted theres one link that hasn't been updated to pass in the tag.
lfdebrux
force-pushed
the
ldeb-add-draft-form-feature-reports--sd
branch
2 times, most recently
from
82318bf to
27030fe
Compare
Rather than going to the reports#live_csv_questions action for the CSV of questions with answer type, we should use the same pattern as for the other feature reports and use the same URL but with a `.csv` appended for the CSV download link on the questions with answer type report page. This commit updates the #questions_with_answer_type action to accept format `csv` as well as `html`, same as the other feature report actions, and uses that in the view template. We can then also simplify the live_questions_csv action. This probably should have been done in PR #1976, but it was missed.
Co-authored-by: Stephen Daly <stephen.daly@digital.cabinet-office.gov.uk>
lfdebrux
force-pushed
the
ldeb-add-draft-form-feature-reports--sd
branch
from
27030fe to
184375e
Compare
The `report_table` helper can't handle it if `records` is an empty list and raises an exception; this commit fixes that by not calling it if `records` is empty. For friendliness, we instead show the user a message making it clear there are no forms/questions to show. For completeness we also make the same change to the questions_with_answer_type report view, even though it's not strictly necessary.
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1991.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
It's helpful to be able to see how many draft forms are using newly released features, as part of measuring uptake of that feature.
This PR parameterises the feature report code by the form document tag, building off the changes in PR #1976 so that this doesn't result in a massively explosive duplication of code.
This PR supersedes #1972.
Things to consider when reviewing