Skip to content

Add feature reports for draft forms#1972

Closed
lfdebrux wants to merge 4 commits intoldeb-refactor-feature-reportsfrom
ldeb-add-draft-form-feature-reports
Closed

Add feature reports for draft forms#1972
lfdebrux wants to merge 4 commits intoldeb-refactor-feature-reportsfrom
ldeb-add-draft-form-feature-reports

Conversation

@lfdebrux
Copy link
Member

What problem does this pull request solve?

It's helpful to be able to see how many draft forms are using newly released features, as part of measuring uptake of that feature.

This PR parameterises the feature report code by the form document tag, building off the changes in PR #1970 so that this doesn't result in a massively explosive duplication of code.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@lfdebrux lfdebrux changed the base branch from main to ldeb-refactor-feature-reports May 21, 2025 14:16
@lfdebrux lfdebrux force-pushed the ldeb-refactor-feature-reports branch 2 times, most recently from 33d7a62 to 1d6cda5 Compare May 23, 2025 09:39
@lfdebrux lfdebrux force-pushed the ldeb-add-draft-form-feature-reports branch from de49f46 to 4ac2d87 Compare May 23, 2025 10:06
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1972.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@lfdebrux
Copy link
Member Author

This has been superseded by #1991.

@lfdebrux lfdebrux closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant