Add feature reports for draft forms#1972
Closed
lfdebrux wants to merge 4 commits intoldeb-refactor-feature-reportsfrom
Closed
Add feature reports for draft forms#1972lfdebrux wants to merge 4 commits intoldeb-refactor-feature-reportsfrom
lfdebrux wants to merge 4 commits intoldeb-refactor-feature-reportsfrom
Conversation
33d7a62 to
1d6cda5
Compare
de49f46 to
4ac2d87
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-1972.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
Member
Author
|
This has been superseded by #1991. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What problem does this pull request solve?
It's helpful to be able to see how many draft forms are using newly released features, as part of measuring uptake of that feature.
This PR parameterises the feature report code by the form document tag, building off the changes in PR #1970 so that this doesn't result in a massively explosive duplication of code.
Things to consider when reviewing