Update build.zig for 0.16 fs.Dir -> Io.Dir #31
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It needs to continue working for 0.15.2 since that is still the latest tagged release. You can try something like |
Author
|
I pegged it to the location of Dir because that seemed the most specific thing to actually look for (and |
jayschwa
requested changes
Jan 12, 2026
build.zig
Outdated
Comment on lines
82
to
86
| // TODO: Remove compatibility shim when Zig 0.16.0 is the minimum required version. | ||
| const open_dir_opts: std.fs.Dir.OpenOptions = if (@hasField(std.fs.Dir.OpenOptions, "follow_symlinks")) | ||
| .{ .access_sub_paths = true, .follow_symlinks = false } | ||
| else | ||
| .{ .access_sub_paths = true, .no_follow = true }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will break existing 0.15.2 builds. I'm not familiar enough with zig's build system to know if there is a way to get information about the zig compiler version to branch off of. If so, then this could easily be patched to support both 0.16 and 0.15.2. As is, it's likely going to break and shouldn't be merged until 0.16 is released.
Maybe a temporary dev branch for zig16 would be useful?