Skip to content

fix DO-1765: Fix PR #103 regressions in node-pr workflow and run-checks action #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheOrangePuff merged 2 commits into from
Mar 31, 2026
Merged

fix DO-1765: Fix PR #103 regressions in node-pr workflow and run-checks action #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abf4ac6
DO-1765: Add clean: false to Nx checkout steps in node-pr workflow
TheOrangePuff Mar 31, 2026
9185040
DO-1765: Fix variable expansion in run-checks action
TheOrangePuff Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/run-checks/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
pm=${INPUTS_PACKAGE_MANAGER}

# Parse JSON array of commands
readarray -t commands < <(echo '${INPUTS_COMMANDS}' | jq -r '.[]')
readarray -t commands < <(echo "${INPUTS_COMMANDS}" | jq -r '.[]')

if [ ${#commands[@]} -gt 0 ]; then
# Build the full command strings
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/node-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ jobs:
with:
fetch-depth: 0
persist-credentials: false
clean: false

- name: Build (nx)
if: steps.check-build.outputs.exists-script != 'true' && steps.check-build.outputs.exists-nx-target == 'true'
Expand Down Expand Up @@ -419,6 +420,7 @@ jobs:
with:
fetch-depth: 0
persist-credentials: false
clean: false

- name: Build commands list
id: build-commands
Expand Down