fix DO-1765: Fix PR #103 regressions in node-pr workflow and run-checks action#120
Merged
TheOrangePuff merged 2 commits intomainfrom Mar 31, 2026
Merged
Conversation
The persist-credentials: false added in PR #103 causes the second checkout to no longer recognise existing repo credentials, triggering a full re-checkout with git clean -ffdx that wipes node_modules/.
Single quotes around ${INPUTS_COMMANDS} prevented bash variable
expansion, causing the command list to always be empty and silently
skipping all checks.
AdamJHall
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Fixes two bugs introduced by PR #103 (DO-1802):
node-pr.yml— Nx checkout steps wipenode_modules/: Thepersist-credentials: falseadded in PR DO-1802: Add Yamllinting, actionlinting and zizmor static analysis #103 causes the secondactions/checkout(for Nx full history) to no longer recognise existing repo credentials, triggering a full re-checkout withgit clean -ffdxthat deletes thenode_modules/directory extracted from a previous artifact step. Fixed by addingclean: falseto both Nx checkout steps (build and test jobs).run-checks/action.yml— Variable expansion broken by single quotes: When${{ inputs.commands }}was moved to an env varINPUTS_COMMANDS, thereadarrayline used single quotes ('${INPUTS_COMMANDS}'), preventing bash variable expansion. This caused the command list to always be empty, silently skipping all checks. Fixed by changing to double quotes.Notes to reviewers
Both bugs were introduced in the same PR (#103) as part of the template injection hardening work.
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback