Updates to Code

DataAccess.cs

@@ -7,7 +7,7 @@ namespace CodeQLAlertTrigger
     public class DataAccess
     {
         private Dictionary<string, string> _users = new Dictionary<string, string>();
-        private const string SqlConnectionString = "Server=localhost;Database=SecurityDb;User Id=sa;Password=MyP@ssw0rd!;";
+        private const string SqlConnectionString = "Server=localhost;Database=SecurityDb;User Id=sa;Password=MyP@ssw0rd!2;";
 
         public DataAccess()
         {
@@ -16,7 +16,7 @@ public DataAccess()
         public bool IsValidUser(string username, string password)
         {
             PopulateUsers();
-            // Should access the database but we wont
+            // Should access the database but we won't
             if (!_users.ContainsKey(username))
             {
                 return false;

SecureAccess.cs

@@ -5,8 +5,8 @@ namespace CodeQLAlertTrigger
 {
     public class SecureAccess
     {
-        private const string AdminUsername = "admin";
-        private const string AdminPassword = "P@ssword123" ;
+        private const string AdminUsername = "adminuser";
+        private const string AdminPassword = "P@ssword1234" ;
         private DataAccess _access = new DataAccess();
 
         public SecureAccess()

terraform/main.tf

@@ -1,13 +1,16 @@
 # Example code taken from:
 # https://aquasecurity.github.io/tfsec/v0.61.3/checks/azure/compute/disable-password-authentication/
+locals {
+  root_password = "P@ssw0rd!1"
+}
 
 resource "azurerm_resource_group" "example" {
   name     = "my-rgrp"
   location = "West US2"
 }
 
 resource "azurerm_storage_account" "bad_example" {
-  name                      = "storageaccountname"
+  name                      = "badnamesa"
   resource_group_name       = azurerm_resource_group.example.name
   location                  = azurerm_resource_group.example.location
   account_tier              = "Standard"
@@ -36,7 +39,7 @@ resource "azurerm_virtual_machine" "bad_example" {
   os_profile {
     computer_name  = "hostname"
     admin_username = "testadmin"
-    admin_password = "Password1234!"
+    admin_password = local.root_password
   }
 
   os_profile_linux_config {
@@ -49,12 +52,18 @@ resource "azurerm_kubernetes_cluster" "bad_example" {
 }
 
 resource "azurerm_key_vault" "bad_example" {
-  name                        = "examplekeyvault"
+  name                        = "bad_examplekeyvault"
   location                    = azurerm_resource_group.example.location
   enabled_for_disk_encryption = true
   purge_protection_enabled    = false
 }
 
+resource "azurerm_key_vault_secret" "example" {
+  name         = "secret_password"
+  value        = var.another_password
+  key_vault_id = azurerm_key_vault.bad_example.id
+}
+
 resource "azurerm_monitor_log_profile" "bad_example" {
   name = "bad_example"
 
@@ -87,3 +96,23 @@ resource "azurerm_network_security_group" "example" {
     destination_address_prefix = "*"
   }
 }
+
+resource "azurerm_app_service_plan" "example" {
+  name                = "bad_exampleappserviceplan"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+}
+
+resource "azurerm_app_service" "bad_example" {
+  name                = "example-app-service"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+  app_service_plan_id = azurerm_app_service_plan.example.id
+}
+
+resource "azurerm_function_app" "bad_example" {
+  name                = "example-function-app"
+  location            = azurerm_resource_group.example.location
+  resource_group_name = azurerm_resource_group.example.name
+  app_service_plan_id = azurerm_app_service_plan.example.id
+}

terraform/variables.tf

@@ -0,0 +1,5 @@
+variable "another_password" {
+  description = "Another Password"
+  type = string
+  default = "P@$$w0rd!"
+}