Updates to Code #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| private Dictionary<string, string> _users = new Dictionary<string, string>(); | ||
| private const string SqlConnectionString = "Server=localhost;Database=SecurityDb;User Id=sa;Password=MyP@ssw0rd!;"; | ||
| private const string SqlConnectionString = "Server=localhost;Database=SecurityDb;User Id=sa;Password=MyP@ssw0rd!2;"; |
Check failure
Code scanning / CodeQL
Hard-coded connection string with credentials
added 2 commits
January 26, 2023 12:48
terraform/main.tf
Outdated
Comment on lines
+113
to
+118
Check failure
Code scanning / defsec
Ensure the Function App can only be accessed via HTTPS. The default is false.
Comment on lines
+106
to
+111
| resource "azurerm_function_app" "bad_example" { | ||
| name = "example-function-app" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| app_service_plan_id = azurerm_app_service_plan.example.id | ||
| } |
Check warning
Code scanning / defsec
App Service authentication is activated
Comment on lines
+106
to
+111
| resource "azurerm_function_app" "bad_example" { | ||
| name = "example-function-app" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| app_service_plan_id = azurerm_app_service_plan.example.id | ||
| } |
Check notice
Code scanning / defsec
Web App has registration with AD enabled
Comment on lines
+106
to
+111
| resource "azurerm_function_app" "bad_example" { | ||
| name = "example-function-app" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| app_service_plan_id = azurerm_app_service_plan.example.id | ||
| } |
Check notice
Code scanning / defsec
Web App uses the latest HTTP version
Comment on lines
+106
to
+111
| resource "azurerm_function_app" "bad_example" { | ||
| name = "example-function-app" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
| app_service_plan_id = azurerm_app_service_plan.example.id | ||
| } |
Check notice
Code scanning / defsec
Web App accepts incoming client certificate
Comment on lines
+61
to
+65
| name = "bad_example" | ||
|
|
||
| retention_policy { | ||
| enabled = true | ||
| days = 7 | ||
| } | ||
| } | ||
|
|
||
| resource "azurerm_network_security_rule" "bad_example" { | ||
| name = "bad_example_security_rule" | ||
| direction = "Inbound" | ||
| access = "Allow" | ||
| protocol = "TCP" | ||
| source_port_range = "*" | ||
| destination_port_range = ["3389"] | ||
| source_address_prefix = "*" | ||
| destination_address_prefix = "*" | ||
| } | ||
|
|
||
| resource "azurerm_network_security_group" "example" { | ||
| name = "tf-appsecuritygroup" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
|
|
||
| security_rule { | ||
| source_port_range = "any" | ||
| destination_port_range = ["3389"] | ||
| source_address_prefix = "*" | ||
| destination_address_prefix = "*" | ||
| } |
Check notice
Code scanning / defsec
Key vault Secret should have a content type set
Comment on lines
+61
to
+65
| name = "bad_example" | ||
|
|
||
| retention_policy { | ||
| enabled = true | ||
| days = 7 | ||
| } | ||
| } | ||
|
|
||
| resource "azurerm_network_security_rule" "bad_example" { | ||
| name = "bad_example_security_rule" | ||
| direction = "Inbound" | ||
| access = "Allow" | ||
| protocol = "TCP" | ||
| source_port_range = "*" | ||
| destination_port_range = ["3389"] | ||
| source_address_prefix = "*" | ||
| destination_address_prefix = "*" | ||
| } | ||
|
|
||
| resource "azurerm_network_security_group" "example" { | ||
| name = "tf-appsecuritygroup" | ||
| location = azurerm_resource_group.example.location | ||
| resource_group_name = azurerm_resource_group.example.name | ||
|
|
||
| security_rule { | ||
| source_port_range = "any" | ||
| destination_port_range = ["3389"] | ||
| source_address_prefix = "*" | ||
| destination_address_prefix = "*" | ||
| } |
Check notice
Code scanning / defsec
Key Vault Secret should have an expiration date set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.