Skip to content

Fix module configuration for central repo release #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuehuitian45 merged 1 commit into from
Jan 20, 2026
Merged

Fix module configuration for central repo release #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,15 @@

<modules>
<module>engine-core</module>
<module>sandbox-core</module>
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The engine-core module (defined on the previous line) has a dependency on this sandbox-core module. In Maven, modules are built in the order they are listed. To ensure a successful build, sandbox-core must be defined before engine-core. Please swap lines 57 and 58.

<module>agents</module>
<module>web</module>
<module>maven_plugin</module>
<module>starters/spring-boot-starter-runtime-a2a</module>
<module>examples/simple_agent_use_rocketmq_example/agentscope_use_rocketmq_server_example</module>
<module>examples/simple_agent_use_rocketmq_example/agentscope_use_rocketmq_client_example</module>
<module>sandbox-core</module>
<module>sandbox-extensions/agentrun-extension</module>
<module>sandbox-extensions/fc-extension</module>
<module>sandbox-extensions/kubernetes-extension</module>
<module>sandbox-extensions/redis-extension</module>
<module>maven_plugin</module>
</modules>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
Expand Down
35 changes: 35 additions & 0 deletions sandbox-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@
</parent>

<artifactId>agentscope-runtime-sandbox-core</artifactId>
<name>AgentScope Runtime Sandbox Core</name>
<description>Java Implementation for AgentScope Runtime</description>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
<organization>
<name>Alibaba Cloud Inc.</name>
<url>https://runtime.agentscope.io</url>
</organization>
<licenses>
<license>
<name>Apache 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>chickenlj</id>
<name>Jun Liu</name>
<email>ken.lj.hz@gmail.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
<developer>
<id>xuehuitian45</id>
<name>Huitian Xue</name>
<email>13069167198@163.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
<developerConnection>git@github.com:agentscope-ai/agentscope-runtime-java.git</developerConnection>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>
Comment on lines +14 to +46
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.


<properties>
<docker-java.version>3.7.0</docker-java.version>
Expand Down
35 changes: 35 additions & 0 deletions sandbox-extensions/agentrun-extension/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@
</parent>

<artifactId>agentrun-extension</artifactId>
<name>AgentScope Runtime Aliyun AgentRun Sandbox Extension</name>
<description>Java Implementation for AgentScope Runtime</description>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
<organization>
<name>Alibaba Cloud Inc.</name>
<url>https://runtime.agentscope.io</url>
</organization>
<licenses>
<license>
<name>Apache 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>chickenlj</id>
<name>Jun Liu</name>
<email>ken.lj.hz@gmail.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
<developer>
<id>xuehuitian45</id>
<name>Huitian Xue</name>
<email>13069167198@163.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
<developerConnection>git@github.com:agentscope-ai/agentscope-runtime-java.git</developerConnection>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>
Comment on lines +14 to +46
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.


<properties>
<agentrun.client.version>4.0.4</agentrun.client.version>
Expand Down
35 changes: 35 additions & 0 deletions sandbox-extensions/fc-extension/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@
</parent>

<artifactId>fc-extension</artifactId>
<name>AgentScope Runtime Aliyun FC Sandbox Extension</name>
<description>Java Implementation for AgentScope Runtime</description>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
<organization>
<name>Alibaba Cloud Inc.</name>
<url>https://runtime.agentscope.io</url>
</organization>
<licenses>
<license>
<name>Apache 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>chickenlj</id>
<name>Jun Liu</name>
<email>ken.lj.hz@gmail.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
<developer>
<id>xuehuitian45</id>
<name>Huitian Xue</name>
<email>13069167198@163.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
<developerConnection>git@github.com:agentscope-ai/agentscope-runtime-java.git</developerConnection>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>
Comment on lines +14 to +46
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.


<dependencies>
<dependency>
Expand Down
35 changes: 35 additions & 0 deletions sandbox-extensions/kubernetes-extension/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@
</parent>

<artifactId>kubernetes-extension</artifactId>
<name>AgentScope Runtime Kubernetes Sandbox Extension</name>
<description>Java Implementation for AgentScope Runtime</description>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
<organization>
<name>Alibaba Cloud Inc.</name>
<url>https://runtime.agentscope.io</url>
</organization>
<licenses>
<license>
<name>Apache 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>chickenlj</id>
<name>Jun Liu</name>
<email>ken.lj.hz@gmail.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
<developer>
<id>xuehuitian45</id>
<name>Huitian Xue</name>
<email>13069167198@163.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
<developerConnection>git@github.com:agentscope-ai/agentscope-runtime-java.git</developerConnection>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>
Comment on lines +14 to +46
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.


<properties>
<kubernetes.client.version>25.0.0</kubernetes.client.version>
Expand Down
35 changes: 35 additions & 0 deletions sandbox-extensions/redis-extension/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@
</parent>

<artifactId>redis-extension</artifactId>
<name>AgentScope Runtime Redis Sandbox Manager Extension</name>
<description>Java Implementation for AgentScope Runtime</description>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
<organization>
<name>Alibaba Cloud Inc.</name>
<url>https://runtime.agentscope.io</url>
</organization>
<licenses>
<license>
<name>Apache 2.0</name>
<url>https://www.apache.org/licenses/LICENSE-2.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
<developers>
<developer>
<id>chickenlj</id>
<name>Jun Liu</name>
<email>ken.lj.hz@gmail.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
<developer>
<id>xuehuitian45</id>
<name>Huitian Xue</name>
<email>13069167198@163.com</email>
<organization>Alibaba Cloud</organization>
<organizationUrl>https://aliyun.com</organizationUrl>
</developer>
</developers>
<scm>
<connection>git://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
<developerConnection>git@github.com:agentscope-ai/agentscope-runtime-java.git</developerConnection>
<url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>
Comment on lines +14 to +46
Copy link

@gemini-code-assist gemini-code-assist bot Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.


<properties>
<redis.client.version>4.0.1</redis.client.version>
Expand Down
Loading