Fix module configuration for central repo release

[chickenlj]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @chickenlj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the necessary configuration adjustments to prepare several modules for release to a central repository. The changes primarily involve standardizing and enriching the pom.xml files with required project metadata and streamlining the overall module structure, ensuring that the components are properly described and discoverable for external consumption.

Highlights

• Module Reorganization: The root pom.xml has been updated to reorder the declaration of modules, moving sandbox-core earlier in the list and maven_plugin later. Additionally, two example modules related to RocketMQ have been removed from the build.
• Central Repository Metadata: Comprehensive metadata has been added to the pom.xml files for sandbox-core and its extensions (agentrun-extension, fc-extension, kubernetes-extension, redis-extension). This includes name, description, url, organization, licenses, developers, and scm information, which is essential for publishing to a central Maven repository.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to configure the project's modules for a central repository release by removing example modules and adding metadata to various pom.xml files. While these changes are necessary for release, I've identified a critical issue with the module build order in the root pom.xml that will cause the build to fail. Additionally, there is significant duplication of metadata across submodule POMs, which should be inherited from the parent to improve maintainability. The SCM information added to these submodules also uses an incorrect format that could cause problems with release tooling.

[gemini-code-assist]

The engine-core module (defined on the previous line) has a dependency on this sandbox-core module. In Maven, modules are built in the order they are listed. To ensure a successful build, sandbox-core must be defined before engine-core. Please swap lines 57 and 58.

[gemini-code-assist]

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.

[gemini-code-assist]

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.

[gemini-code-assist]

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.

[gemini-code-assist]

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.

[gemini-code-assist]

The url, organization, licenses, developers, and scm elements are duplicated from the parent pom.xml. This information is inherited by default, and duplicating it in each module increases maintenance overhead and can lead to inconsistencies. The recommended practice is to remove this redundant configuration and rely on inheritance from the parent POM.

Furthermore, if you decide to keep this configuration, the scm block is incorrectly formatted. It's missing the scm:git: prefix required by Maven, and the git:// protocol is outdated. This will likely cause issues with release plugins. The correct format would be:

<scm>
    <connection>scm:git:https://github.com/agentscope-ai/agentscope-runtime-java.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/agentscope-ai/agentscope-runtime-java.git</developerConnection>
    <url>https://github.com/agentscope-ai/agentscope-runtime-java</url>
</scm>

Given the redundancy, the best solution is to remove this entire block.

[xuehuitian45]

LGTM